feat: stop hardcoding fdcan in platformspecific#67
Draft
Ilyhadev wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
Platform specific owned driver on can which didn't relate to protocol functionality |
Collaborator
Author
|
This PR is up to discussion/edit because it proposes to decouple library from HAL and pass ownership of basic can driver to application. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAN was owned fully by this library. For future development, when CAN may be used by another libraries, it's better to move decision on CAN ownership to application which configures corresponding FDCANs