Skip to content

fix(inbox): restore Scout in the source filter dropdown#2587

Merged
andrewm4894 merged 1 commit into
mainfrom
fix/inbox-scout-source-filter
Jun 10, 2026
Merged

fix(inbox): restore Scout in the source filter dropdown#2587
andrewm4894 merged 1 commit into
mainfrom
fix/inbox-scout-source-filter

Conversation

@andrewm4894

Copy link
Copy Markdown
Member

Problem

Inbox 2.0 (#2547) rebuilt the source filter from a new INBOX_SOURCE_OPTIONS list and dropped the signals_scout entry added in #2505. Scout-sourced reports could no longer be filtered: the dropdown had no Scout row, and a persisted Scout filter rendered its chip with the raw signals_scout value because the label lookup falls back to the raw string when no option matches.

Changes

  • Add Scout (signals_scout, compass icon) back to INBOX_SOURCE_OPTIONS in packages/ui/src/features/inbox/filterOptions.tsx, so the source dropdown lists Scout again and the filter chip reads "Scout".
  • Reword the inbox CLAUDE.md rule that said "Do not add Scout UI until a corresponding backend exists in this repo" — it reads as if Scout shouldn't appear anywhere, which is likely how the filter entry got dropped. It now states Scout is a real Cloud source product that must stay covered in filter options, source meta, and signal cards, and scopes the prohibition to Scout management UI (fleet configuration, run history).

Scout coverage that survived 2.0 and is unchanged here: SOURCE_PRODUCT_META badges and the scout-name source line on SignalCard (#2538).

How did you test this?

  • pnpm --filter @posthog/ui typecheck passes.
  • pnpm --filter @posthog/ui test — 690 tests pass.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@andrewm4894 andrewm4894 self-assigned this Jun 10, 2026
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(inbox): restore Scout in the source ..." | Re-trigger Greptile

@andrewm4894 andrewm4894 added the Stamphog This will request an autostamp by stamphog on small changes label Jun 10, 2026
@andrewm4894 andrewm4894 enabled auto-merge (squash) June 10, 2026 21:26

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial additive UI change — adds a Scout entry to the source filter dropdown and updates the local CLAUDE.md guidance to match. No logic changes, no data model impact, no security concerns.

@andrewm4894 andrewm4894 merged commit 6b135fa into main Jun 10, 2026
17 of 19 checks passed
@andrewm4894 andrewm4894 deleted the fix/inbox-scout-source-filter branch June 10, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant