Skip to content

fix(inbox): restore Scout in the source filter dropdown #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewm4894 merged 1 commit into from
Jun 10, 2026
Merged

fix(inbox): restore Scout in the source filter dropdown #2587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/features/inbox/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ When adding or changing UI, reuse those primitives first. Avoid encoding one-off
- Do not reuse the deleted legacy `ReportListRow`, `ReportDetailPane`, or old list/detail stores.
- Do not put page-level Inbox title or navigation into the global app header; `InboxView` owns the Inbox page chrome.
- Do not add a configure shortcut back into the Inbox header; Responders configuration is a sidebar destination.
- Do not add Scout UI until a corresponding backend exists in this repo.
- Scout (`signals_scout`) is a real Cloud source product. Keep it covered wherever source products surface: `INBOX_SOURCE_OPTIONS`, `SOURCE_PRODUCT_META`, and the scout-name display in `SignalCard`. Do not add Scout management UI (fleet configuration, run history) until a corresponding backend exists in this repo.
- Do not put preview shims or mock report data in `apps/code/index.html`; the app shell should stay minimal.
- Do not call `electronTRPC` directly from Inbox code. Use the existing API client, React Query hooks, or tRPC client wrappers.
- Do not preserve compatibility with unshipped intermediate UI shapes on this branch. Replace them cleanly.
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/features/inbox/filterOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
BugIcon,
CalendarPlus,
Clock,
CompassIcon,
GithubLogoIcon,
KanbanIcon,
LifebuoyIcon,
Expand Down Expand Up @@ -99,6 +100,7 @@ export const INBOX_SOURCE_OPTIONS: {
icon: <LifebuoyIcon size={14} />,
},
{ value: "pganalyze", label: "pganalyze", icon: <PgAnalyzeIcon size={14} /> },
{ value: "signals_scout", label: "Scout", icon: <CompassIcon size={14} /> },
];

export function inboxSortOptionKey(
Expand Down
Loading