test: fix Python 3.10 Tests CI (surge namespace-shadow test)#38
Merged
Conversation
test_namespace_shadow_not_false_positive asserted surge reports "missing" (red), but on Python 3.10/3.11 _dep_status short-circuits to the "needs Python 3.12-3.14" gate (yellow) before reaching the namespace-shadow probe, so the test failed on the py3.10 matrix leg. Bypass the gate via monkeypatch so the probe path is exercised on every Python version; the generic probe_installed namespace logic stays covered by test_runner.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
Testsworkflow on the py3.10 matrix leg.test_namespace_shadow_not_false_positiveexpected surge to reportred(missing), but on Python 3.10/3.11_dep_statusshort-circuits to theneeds Python 3.12-3.14gate (yellow) before reaching the namespace-shadow probe - so the assertion failed on 3.10 while passing on 3.12. The test now bypasses the gate via monkeypatch so it exercises the probe path on every Python version. The genericprobe_installednamespace logic remains covered bytest_runner.py.?? Generated with Claude Code