Skip to content

test: fix Python 3.10 Tests CI (surge namespace-shadow test) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qian-harvard merged 1 commit into from
Jun 11, 2026
Merged

test: fix Python 3.10 Tests CI (surge namespace-shadow test) #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/test_doctor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,14 @@ def test_path_status_missing_and_configured(isolated_config):
assert style == "green"


def test_namespace_shadow_not_false_positive():
# surge-py is NOT installed in the core test venv. The repo's lowercase
# surge/ directory must not be mistaken for the installed library (PEP 420
# namespace shadow), so the dependency must report missing, not ok.
def test_namespace_shadow_not_false_positive(monkeypatch):
# surge-py is NOT installed in the test venv. The repo's lowercase surge/
# directory must not be mistaken for the installed library (PEP 420 namespace
# shadow), so the dependency must report missing, not ok. Bypass surge's
# Python-version gate (it is 3.12-3.14 only) so this exercises the probe path
# on every Python version — otherwise on 3.10/3.11 _dep_status short-circuits
# to the "needs Python 3.12-3.14" warning before reaching the probe.
monkeypatch.setattr(doctor, "_surge_supported", lambda: True)
style, msg = doctor._dep_status(get_tool("surge"))
assert style == "red", f"expected surge missing, got {style}: {msg}"

Expand Down
Loading