Skip to content

fix: add contentDescription to selection-state icons for screen readers#400

Open
kunwarshivamjsr wants to merge 1 commit into
ProdigyV21:mainfrom
kunwarshivamjsr:fix/a11y-selection-state-icons
Open

fix: add contentDescription to selection-state icons for screen readers#400
kunwarshivamjsr wants to merge 1 commit into
ProdigyV21:mainfrom
kunwarshivamjsr:fix/a11y-selection-state-icons

Conversation

@kunwarshivamjsr

Copy link
Copy Markdown

What this fixes

Adds proper contentDescription values to selection-state icons (CheckCircle/RadioButtonUnchecked) in SettingsScreen.kt (IPTV playlist and catalog selection rows). Previously these used contentDescription = null, so TalkBack gave no audio feedback on whether an item was selected when navigating with a D-pad on Android TV.

Changes

  • Added item_selected / item_not_selected string resources in strings.xml
  • Updated 2 icon usages in IptvSettings() and CatalogsSettings() composables to use stringResource() reflecting current selection state

Testing

Closes #399


🙏 First-time contributor here for GSSoC — would appreciate a review and the gssoc:approved + difficulty label if this looks good. Thanks!

Adds proper contentDescription values to CheckCircle/RadioButtonUnchecked
icons in SettingsScreen.kt (IPTV playlist and catalog selection rows)
that indicate selection state, improving TalkBack accessibility on
Android TV.
Refs ProdigyV21#399
@ProdigyV21

Copy link
Copy Markdown
Owner

Can you show screenshots and tests of how it looks and works inside app?

@kunwarshivamjsr

Copy link
Copy Markdown
Author

Hi @ProdigyV21 — this fix changes contentDescription on the selection-state icons from null to a stringResource that reflects the current state ("Selected" / "Not selected"), so TalkBack announces the state when a user navigates to a row with a D-pad.

Since this is a screen-reader accessibility fix rather than a visual change, it isn't visible in a static screenshot — the behaviour surfaces only through TalkBack's audio output.

I don't currently have access to an Android TV device to record a TalkBack demo. If you can run the build locally, the change is in SettingsScreen.kt (IptvSettings and CatalogsSettings composables) — navigate to playlist/catalog selection with TalkBack enabled and it should now announce the selection state correctly.

Happy to try setting up an emulator and recording a screen capture if that would help. Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A11y] Selection-state icons (Check/CheckCircle/RadioButtonUnchecked) missing contentDescription for screen reader users

2 participants