Skip to content

fix: add contentDescription to selection-state icons for screen readers #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunwarshivamjsr wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: add contentDescription to selection-state icons for screen readers #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/kotlin/com/arflix/tv/ui/screens/settings/SettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5884,7 +5884,7 @@ private fun IptvSettings(
verticalAlignment = Alignment.CenterVertically
) {
if (selectionMode) {
Icon(imageVector = if (isSelected) Icons.Default.CheckCircle else Icons.Default.RadioButtonUnchecked, contentDescription = null, tint = if (isSelected) Pink else TextSecondary, modifier = Modifier.size(24.dp))
Icon(imageVector = if (isSelected) Icons.Default.CheckCircle else Icons.Default.RadioButtonUnchecked, contentDescription = stringResource(if (isSelected) R.string.item_selected else R.string.item_not_selected), tint = if (isSelected) Pink else TextSecondary, modifier = Modifier.size(24.dp))
Spacer(modifier = Modifier.width(16.dp))
} else {
Icon(imageVector = Icons.Default.LiveTv, contentDescription = null, tint = TextSecondary, modifier = Modifier.size(24.dp))
Expand Down Expand Up @@ -6919,7 +6919,7 @@ private fun CatalogsSettings(
verticalAlignment = Alignment.CenterVertically
) {
if (selectionMode) {
Icon(if (isSelected) Icons.Default.CheckCircle else Icons.Default.RadioButtonUnchecked, contentDescription = null, tint = if (isSelected) Pink else TextSecondary, modifier = Modifier.size(24.dp))
Icon(if (isSelected) Icons.Default.CheckCircle else Icons.Default.RadioButtonUnchecked, contentDescription = stringResource(if (isSelected) R.string.item_selected else R.string.item_not_selected), tint = if (isSelected) Pink else TextSecondary, modifier = Modifier.size(24.dp))
Spacer(modifier = Modifier.width(16.dp))
} else {
Icon(Icons.Default.Widgets, contentDescription = null, tint = TextSecondary, modifier = Modifier.size(24.dp))
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
<string name="add">Add</string>
<string name="refresh">Refresh</string>
<string name="selected">selected</string>
<string name="item_selected">Selected</string>
<string name="item_not_selected">Not selected</string>
<string name="sign_in">Sign In</string>
<string name="log_out">Log Out</string>
<string name="watched">Watched</string>
Expand Down