Attach strategy plugin metadata#50
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd1c81a9b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| required_semiconductor_rotation_history_lookback, | ||
| ) | ||
| from quant_platform_kit.common.strategy_plugins import ( | ||
| attach_strategy_plugin_metadata, |
There was a problem hiding this comment.
In a fresh install using this repo's requirements.txt, quant-platform-kit is pinned to ceb84a366ed1bf9a53292ff2c73e06b4baac05e2, and I checked that revision's strategy_plugins.py does not export attach_strategy_plugin_metadata. This new import therefore raises ImportError as soon as application.rebalance_service is imported, preventing the service and tests that import it from starting unless the dependency pin is updated or the helper call is guarded/implemented locally.
Useful? React with 👍 / 👎.
1 participant
Summary:\n- Attach allowed strategy plugin metadata to Firstrade portfolio snapshots before strategy evaluation\n\nValidation:\n- ./.venv/bin/python -m pytest tests/test_rebalance_service.py -q\n- git diff --check HEAD~1..HEAD\n\nNote:\n- Ruff is not installed in this repo venv.