Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions application/rebalance_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
required_semiconductor_rotation_history_lookback,
)
from quant_platform_kit.common.strategy_plugins import (
attach_strategy_plugin_metadata,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the QuantPlatformKit pin for this helper

In a fresh install using this repo's requirements.txt, quant-platform-kit is pinned to ceb84a366ed1bf9a53292ff2c73e06b4baac05e2, and I checked that revision's strategy_plugins.py does not export attach_strategy_plugin_metadata. This new import therefore raises ImportError as soon as application.rebalance_service is imported, preventing the service and tests that import it from starting unless the dependency pin is updated or the helper call is guarded/implemented locally.

Useful? React with 👍 / 👎.

build_strategy_plugin_report_payload,
load_configured_strategy_plugin_signals,
parse_strategy_plugin_mounts,
Expand Down Expand Up @@ -327,6 +328,7 @@ def run_strategy_cycle(
portfolio_port = broker_adapters.build_portfolio_port()
execution_port = broker_adapters.build_execution_port()
snapshot = portfolio_port.get_portfolio_snapshot()
snapshot = attach_strategy_plugin_metadata(snapshot, strategy_plugin_signals)

available_inputs = set(strategy_runtime.runtime_adapter.available_inputs)
benchmark_symbol = str(strategy_runtime.merged_runtime_config.get("benchmark_symbol", "QQQ"))
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
flask
gunicorn
firstrade==0.0.38
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@ceb84a366ed1bf9a53292ff2c73e06b4baac05e2
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@f2ebae8aacd8c70292c5b6115a80c6657e64ad1f
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@86d72631c76f27c668b234704b91241bec8fa9ee
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@5f04e85e89862fdcfa8d90e745340eabdbbe3c86
google-cloud-storage
requests
pytest