Skip to content

Rename Google Voice target to recipients#53

Merged
Pigbibi merged 1 commit into
mainfrom
codex-googlevoice-recipients
May 25, 2026
Merged

Rename Google Voice target to recipients#53
Pigbibi merged 1 commit into
mainfrom
codex-googlevoice-recipients

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename the Google Voice notification target from gateway to recipients
  • keep the channel-specific config names while treating the destination as email-form recipients
  • document that normal email recipients receive mail, while Google Voice addresses can also surface GV prompts

Tests

  • PYTHONPATH=src pytest tests/test_google_voice_notifications.py tests/test_strategy_plugins.py
  • PYTHONPATH=src ruff check .

@Pigbibi Pigbibi merged commit 705667f into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex-googlevoice-recipients branch May 25, 2026 09:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ceec1c7bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

gateway_recipients=tuple(
parse_email_recipients(_get_value(value, "crisis_alert_google_voice_gateway", ()))
recipients=tuple(
parse_email_recipients(_get_value(value, "crisis_alert_google_voice_recipients", ()))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve legacy gateway key during recipients migration

This change makes StrategyPluginGoogleVoiceSettings.from_object read only crisis_alert_google_voice_recipients, so existing environments that still provide CRISIS_ALERT_GOOGLE_VOICE_GATEWAY will now parse zero recipients and be treated as misconfigured, causing every Google Voice alert to be skipped with missing_google_voice_config. Because this is a runtime config regression for already-deployed setups, the loader should accept both keys (at least during a deprecation window).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant