Rename Google Voice target to recipients#53
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ceec1c7bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gateway_recipients=tuple( | ||
| parse_email_recipients(_get_value(value, "crisis_alert_google_voice_gateway", ())) | ||
| recipients=tuple( | ||
| parse_email_recipients(_get_value(value, "crisis_alert_google_voice_recipients", ())) |
There was a problem hiding this comment.
Preserve legacy gateway key during recipients migration
This change makes StrategyPluginGoogleVoiceSettings.from_object read only crisis_alert_google_voice_recipients, so existing environments that still provide CRISIS_ALERT_GOOGLE_VOICE_GATEWAY will now parse zero recipients and be treated as misconfigured, causing every Google Voice alert to be skipped with missing_google_voice_config. Because this is a runtime config regression for already-deployed setups, the loader should accept both keys (at least during a deprecation window).
Useful? React with 👍 / 👎.
Summary
Tests