Add Clone derive to Error enum#78
Open
smalis-msft wants to merge 1 commit into
Open
Conversation
newpavlov
reviewed
May 15, 2026
| use core::fmt; | ||
|
|
||
| /// Errors emitted from the wrap and unwrap operations. | ||
| #[derive(Debug, PartialEq, Eq)] |
Member
There was a problem hiding this comment.
Probably also worth to derive Copy and Hash as well.
Author
There was a problem hiding this comment.
I'm hesitant to add Copy because it can become very restrictive if more variants are added in the future. As for Hash, are errors likely to be used as hashmap keys? I think this current set of traits is the right set of tradeoffs, and consistent with most of the other RustCrypto crates' error enums.
Member
There was a problem hiding this comment.
Since this enum is not marked with #[non_exhaustive] addition of new variants would be a breaking change anyway. Derivation of Hash is just for completeness sake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.