Skip to content

Add Clone derive to Error enum #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smalis-msft wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Clone derive to Error enum #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aes-kw/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use core::fmt;

/// Errors emitted from the wrap and unwrap operations.
#[derive(Debug, PartialEq, Eq)]
Copy link
Copy Markdown
Member

@newpavlov newpavlov May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also worth to derive Copy and Hash as well.

Copy link
Copy Markdown
Author

@smalis-msft smalis-msft May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to add Copy because it can become very restrictive if more variants are added in the future. As for Hash, are errors likely to be used as hashmap keys? I think this current set of traits is the right set of tradeoffs, and consistent with most of the other RustCrypto crates' error enums.

Copy link
Copy Markdown
Member

@newpavlov newpavlov May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this enum is not marked with #[non_exhaustive] addition of new variants would be a breaking change anyway. Derivation of Hash is just for completeness sake.

#[derive(Clone, Debug, PartialEq, Eq)]
pub enum Error {
/// Input data length invalid.
InvalidDataSize,
Expand Down
Loading