feat: context propagation and operation type attributes#6
Merged
Conversation
# Conflicts: # src/sap_cloud_sdk/core/telemetry/user-guide.md
NicoleMGomes
approved these changes
Mar 23, 2026
cassiofariasmachado
approved these changes
Mar 23, 2026
14 tasks
This was referenced Jul 6, 2026
tiagoek
added a commit
that referenced
this pull request
Jul 7, 2026
…uto-detect Three new FP classes discovered in the post-remediation dry-run (85 real Python PRs, 10 Java PRs). Empirical validation showed the initial fix wave left gaps that produced 1000+ noise findings on subsequent PRs. - FP-H-01: HC-01 no longer scans lockfiles (uv.lock, poetry.lock, Pipfile.lock, package-lock.json, yarn.lock, Cargo.lock, Gemfile.lock, *.lock). These are generated files full of package registry URLs. Impact: eliminates ~800 false BLOCKs on PRs that touch uv.lock. - FP-I-01: HC-01 no longer scans .env / .env.* / .env_* / .env-* files. These are convention/template files carrying placeholder URLs like 'your-api-url-here'. Impact: eliminates ~14 false BLOCKs. - FP-J-01: check-license-spdx auto-detects whether the repo has consistent SPDX adoption. If < 20% of existing files carry SPDX headers, LIC-01/02 is held (returns PASS with a pass_criteria_met explanation) rather than penalizing every new file for a debt the repo itself carries. Impact: eliminates 12 false BLOCKs on cloud-sdk-java PR #6 (Number Range module). Regression tests: +5 bats tests in test_fp_remediation.bats (76 total, all green in both repos).
tiagoek
added a commit
that referenced
this pull request
Jul 7, 2026
…uto-detect Three new FP classes discovered in the post-remediation dry-run (85 real Python PRs, 10 Java PRs). Empirical validation showed the initial fix wave left gaps that produced 1000+ noise findings on subsequent PRs. - FP-H-01: HC-01 no longer scans lockfiles (uv.lock, poetry.lock, Pipfile.lock, package-lock.json, yarn.lock, Cargo.lock, Gemfile.lock, *.lock). These are generated files full of package registry URLs. Impact: eliminates ~800 false BLOCKs on PRs that touch uv.lock. - FP-I-01: HC-01 no longer scans .env / .env.* / .env_* / .env-* files. These are convention/template files carrying placeholder URLs like 'your-api-url-here'. Impact: eliminates ~14 false BLOCKs. - FP-J-01: check-license-spdx auto-detects whether the repo has consistent SPDX adoption. If < 20% of existing files carry SPDX headers, LIC-01/02 is held (returns PASS with a pass_criteria_met explanation) rather than penalizing every new file for a debt the repo itself carries. Impact: eliminates 12 false BLOCKs on cloud-sdk-java PR #6 (Number Range module). Regression tests: +5 bats tests in test_fp_remediation.bats (76 total, all green in both repos).
tiagoek
added a commit
that referenced
this pull request
Jul 7, 2026
…uto-detect Three new FP classes discovered in the post-remediation dry-run (85 real Python PRs, 10 Java PRs). Empirical validation showed the initial fix wave left gaps that produced 1000+ noise findings on subsequent PRs. - FP-H-01: HC-01 no longer scans lockfiles (uv.lock, poetry.lock, Pipfile.lock, package-lock.json, yarn.lock, Cargo.lock, Gemfile.lock, *.lock). These are generated files full of package registry URLs. Impact: eliminates ~800 false BLOCKs on PRs that touch uv.lock. - FP-I-01: HC-01 no longer scans .env / .env.* / .env_* / .env-* files. These are convention/template files carrying placeholder URLs like 'your-api-url-here'. Impact: eliminates ~14 false BLOCKs. - FP-J-01: check-license-spdx auto-detects whether the repo has consistent SPDX adoption. If < 20% of existing files carry SPDX headers, LIC-01/02 is held (returns PASS with a pass_criteria_met explanation) rather than penalizing every new file for a debt the repo itself carries. Impact: eliminates 12 false BLOCKs on cloud-sdk-java PR #6 (Number Range module). Regression tests: +5 bats tests in test_fp_remediation.bats (76 total, all green in both repos).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reframes the telemetry mental model around autoinstrumentation as the primary layer, with custom spans adding business context via a parent span rather than wrapping LLM calls directly. Adds
propagateparameter in context overlays for attribute propagation as opt-inType of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following: