Avoid indenting after endless method definition#4041
Open
Conversation
This was referenced Mar 31, 2026
st0012
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3997
The automatic indentation rules that are bundled in VS Code don't account for endless method definitions and end up advancing the indentation when you break the line (which isn't what you'd expect).
This PR adds our own indentation rules to validate the fix first. Once we know this works correctly, we can contribute the improvement to VS Code and get rid of this.
Implementation
The rules become more complicated because we now need a negative lookahead that can catch and endless method definition without confusing it with a setter name. Using a setter name with an endless method definition is actually a syntax error, but we don't want to indent anyway.
Example: