Conversation
WalkthroughUpdated CommonLibs version dependencies in the project configuration. The stable version incremented from 4.6.0 to 4.6.1, and the release version transitioned from a dev-tagged build to the stable 4.6.1 release. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Sharphound.csproj`:
- Around line 18-19: The project currently bumps CommonLibsStableVersion to
4.6.1 which yields a derived dev wildcard (e.g., 4.6.2-dev*) and, since
CommonSource defaults to Dev, the restore attempts to fetch non-existent
4.6.2-dev packages for SharpHoundCommon/SharpHoundRPC; change the default
CommonSource value from Dev to Release (so the resolver uses the released
CommonLibsReleaseVersion) or, if you prefer keeping Dev default, ensure the
corresponding 4.6.2-dev NuGet packages are published before merging; update the
CommonSource default declaration accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| <CommonLibsStableVersion>4.6.1</CommonLibsStableVersion> | ||
| <CommonLibsReleaseVersion>4.6.1</CommonLibsReleaseVersion> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
find . -name "Sharphound.csproj" -type fRepository: SpecterOps/SharpHound
Length of output: 84
🏁 Script executed:
cat -n ./Sharphound.csproj | head -50Repository: SpecterOps/SharpHound
Length of output: 3144
🏁 Script executed:
cat -n ./Sharphound.csproj | grep -A 5 "SharpHoundCommon\|SharpHoundRPC" | head -30Repository: SpecterOps/SharpHound
Length of output: 1793
🏁 Script executed:
git log --oneline -20 -- Sharphound.csprojRepository: SpecterOps/SharpHound
Length of output: 93
Build is blocked by implicit switch to an unavailable dev package version.
Line 18 bumps the stable version to 4.6.1, which causes the derived dev wildcard (line 28) to become 4.6.2-dev*. Because CommonSource defaults to Dev (line 30), the package resolution at lines 67-68 attempts to restore 4.6.2-dev* versions of SharpHoundCommon and SharpHoundRPC, which don't exist until published.
Proposed fix
Change the default CommonSource from Dev to Release:
- <CommonSource>Dev</CommonSource>
+ <CommonSource>Release</CommonSource>Alternatively, ensure 4.6.2-dev packages are published to NuGet before merging.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Sharphound.csproj` around lines 18 - 19, The project currently bumps
CommonLibsStableVersion to 4.6.1 which yields a derived dev wildcard (e.g.,
4.6.2-dev*) and, since CommonSource defaults to Dev, the restore attempts to
fetch non-existent 4.6.2-dev packages for SharpHoundCommon/SharpHoundRPC; change
the default CommonSource value from Dev to Release (so the resolver uses the
released CommonLibsReleaseVersion) or, if you prefer keeping Dev default, ensure
the corresponding 4.6.2-dev NuGet packages are published before merging; update
the CommonSource default declaration accordingly.
3 participants
Description
updating to the latest SHC version
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit