Skip to content

using latest SHC lib #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmanuelrobles wants to merge 1 commit into
base: 2.X
Choose a base branch
from
Open

using latest SHC lib #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sharphound.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
</PropertyGroup>

<PropertyGroup>
<CommonLibsStableVersion>4.6.0</CommonLibsStableVersion>
<CommonLibsReleaseVersion>4.6.1-dev.202604031715</CommonLibsReleaseVersion>
<CommonLibsStableVersion>4.6.1</CommonLibsStableVersion>
<CommonLibsReleaseVersion>4.6.1</CommonLibsReleaseVersion>
Comment on lines +18 to +19
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

find . -name "Sharphound.csproj" -type f

Repository: SpecterOps/SharpHound

Length of output: 84

🏁 Script executed:

cat -n ./Sharphound.csproj | head -50

Repository: SpecterOps/SharpHound

Length of output: 3144

🏁 Script executed:

cat -n ./Sharphound.csproj | grep -A 5 "SharpHoundCommon\|SharpHoundRPC" | head -30

Repository: SpecterOps/SharpHound

Length of output: 1793

🏁 Script executed:

git log --oneline -20 -- Sharphound.csproj

Repository: SpecterOps/SharpHound

Length of output: 93

Build is blocked by implicit switch to an unavailable dev package version.

Line 18 bumps the stable version to 4.6.1, which causes the derived dev wildcard (line 28) to become 4.6.2-dev*. Because CommonSource defaults to Dev (line 30), the package resolution at lines 67-68 attempts to restore 4.6.2-dev* versions of SharpHoundCommon and SharpHoundRPC, which don't exist until published.

Proposed fix

Change the default CommonSource from Dev to Release:

-        <CommonSource>Dev</CommonSource>
+        <CommonSource>Release</CommonSource>

Alternatively, ensure 4.6.2-dev packages are published to NuGet before merging.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Sharphound.csproj` around lines 18 - 19, The project currently bumps
CommonLibsStableVersion to 4.6.1 which yields a derived dev wildcard (e.g.,
4.6.2-dev*) and, since CommonSource defaults to Dev, the restore attempts to
fetch non-existent 4.6.2-dev packages for SharpHoundCommon/SharpHoundRPC; change
the default CommonSource value from Dev to Release (so the resolver uses the
released CommonLibsReleaseVersion) or, if you prefer keeping Dev default, ensure
the corresponding 4.6.2-dev NuGet packages are published before merging; update
the CommonSource default declaration accordingly.

<CommonLibPath>..\SharpHoundCommon\src\CommonLib\bin\$(Configuration)\net472\SharpHoundCommonLib.dll</CommonLibPath>
<RPCPath>..\SharpHoundCommon\src\SharpHoundRPC\bin\$(Configuration)\net472\SharpHoundRPC.dll</RPCPath>

Expand Down
Loading