Repository navigation
Point each exported chart series at its own column (#59) - #240
Merged
Merged
Conversation
chartDataFrom skips a column with no numbers, so a text column between the labels and the numbers is not a series. seriesRefsFrom counted the series' position instead of their column, so with Branch | Notes | Q1 | Q2 the exported chart referred to Notes and Q1. The app's chart was right, but Excel re-reads the references and drew the wrong data. ChartSeries now carries the column it came from, and the references are built from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pmWZsbmugfpqtYazrzfjj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pmWZsbmugfpqtYazrzfjj
Brings in #51's later commits, #235 and #219. Only the counts conflicted; recounted to 2014 tests in 145 files, picture 27 retaken in both languages and the social card rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pmWZsbmugfpqtYazrzfjj
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
PO review: merged at
I tried it as a user on a production build. I typed the issue's table,
After this merge, the hold set has one ticket left: #241. Opening an Generated by Claude Code |
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #59, the last of the sprint-final queue. This takes the fix route, not the README-limit route. The fix is the small one #59 itself suggests: carry each series' source column in
ChartSeries, with a test that fails onmain.The bug:
chartDataFromskips a column with no numbers, so a text column between the labels and the numbers is not a series.seriesRefsFrombuilt each reference from the series' position (startCol + labelOffset + index), not from its column. WithBranch | Notes | Q1 | Q2, the exported chart therefore referred to Notes and Q1. The chart in the app was right, and the cached values in the file were right too. But Excel re-reads the references, so it drew the wrong data.The fix:
ChartSeriesgainscolumn: the column it was read from, counted from the range's first column.chartDataFromfills it in.seriesRefsFrombuilds the name and value references from that column. The same goes for a pie's chosen series, which usedseriesIndexas a column offset in the same way.points, as before.Reproduced on
mainfirstThe steps are the issue's:
Branch | Notes | Q1 | Q2with 4 rows, A1:D5, bar chart, export.mainSheet1!$B$1,$B$2:$B$5(Notes)Sheet1!$C$1,$C$2:$C$5Sheet1!$C$1,$C$2:$C$5(Q1)Sheet1!$D$1,$D$2:$D$5$C$2:$C$5(Q1)$D$2:$D$5(Q2)$A$2:$A$5$A$2:$A$5How it was verified
npm run verify(all ten gates): all ten gates green ond09e01c. The current head6f54079carries that tree unchanged; it only adds the merges of เซลล์รูปแบบเวลาสะสม [h]:mm โชว์ชั่วโมงของวันแทนชั่วโมงรวม · Elapsed-time formats like [h]:mm show the hour of the day #219's head and then ofmain7c2bb7f(Show zero and negative date serials as Excel does (#219) #239).xlsxCharts.test.ts: "points each series at its own column when a text column sits between them ([area:charts] กราฟในไฟล์ .xlsx ที่ส่งออกชี้คอลัมน์ผิด เมื่อมีคอลัมน์ข้อความคั่น · Charts in the exported .xlsx point at the wrong columns (sev:high) #59)". It exports the issue's table with a bar chart and a pie of the second series, opens the real.xlsx, and readsxl/charts/chart1.xmlandchart2.xml.main'sxlsxChartXml.ts, the new test fails (no$D$1).seriesRefsFromandvalueExtentfixtures gain the new field. Nothing else in them changes..xlsxis a real chart", saying each series refers to the column it was read from, and what went wrong before.The branch
Head:
claude/new-session-m6mehm-59, a second branch the owner allowed so #219 and #59 could be open together. It was opened stacked on PR #239; now that #239 is inmain, its base ismain, and the merge ofmainwas pushed after the base changed so CI and CodeQL run againstmain.🤖 Generated with Claude Code
https://claude.ai/code/session_013pmWZsbmugfpqtYazrzfjj