Gate rebuilds on native GPU proof#1028
Merged
TheGreenCedar merged 5 commits intoJul 12, 2026
Merged
Conversation
c15a384 to
d4828a5
Compare
d4828a5 to
02832a1
Compare
02832a1 to
1316b2d
Compare
1316b2d to
2c9af43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Agent sidecar repair could begin a long semantic rebuild after detecting an accelerator and reaching the embedding endpoint without proving that the exact selected runtime performed meaningful accelerator work. A failed retry could also leave an older verified broker proof visible.
Closes #1025
Refs #884
What Changed
gpu_unverifiedon gate failureCI Failure and Root Fix
The first workspace run failed four
retrieval_bootstrap_contractsbecause Docker identity persistence inspected a container even for--skip-composebootstrap. The initial correction exposed a second lifecycle edge: identity captured before a possible force-recreate could immediately become stale.The final path leaves skip-compose bootstrap observational, performs any Compose refresh first, then captures the final running container ID/start tuple and atomically writes it into sidecar state. The Agent rebuild gate still fails closed when no bound identity exists.
How To Review
ensure_embedding_accelerator_smoke_for_runtimethrough native, Docker, external, and CPU-allowed branches.run_ready_repair_with_native_embedding_leaseand Agentretrieval indexinvoke the gate beforerun_indexing_blocking.--skip-compose.Verification
cargo test -p codestory-cli --test retrieval_bootstrap_contracts --locked -- --nocapture— 6 passedcargo test -p codestory-retrieval sidecar_state_replacement_is_complete_and_leaves_no_temp_file --locked -- --nocapture— passed; covers atomic recreated-identity replacementcargo test -p codestory-retrieval --locked— 337 passed, 2 ignored; integration suites passedcargo test -p codestory-retrieval accelerator_smoke -- --nocapture— 4 passedcargo test -p codestory-retrieval container_identity_requires_running_state -- --nocapture— passedcargo test -p codestory-cli failed_smoke_replaces_verified_proof_for_current_runtime -- --nocapture— passedcargo test -p codestory-cli ready_repair_ --locked -- --nocapture— 35 unit tests and ready-command integration passedcargo clippy -p codestory-retrieval -p codestory-cli --all-targets --all-features --locked -- -D warningsnode .github/scripts/check-doc-links.mjsgit diff --checkRisk
The gate intentionally fails closed for accelerator-required external endpoints because CodeStory cannot bind provider-owned process/log identity. Live physical-GPU proof remains a post-merge environment check; deterministic tests cover the decision logic without requiring GPU hardware. No screenshot-visible UI changed.