guard non-rust evidence boundaries#1056
Merged
Merged
Conversation
7 tasks
2fbe266 to
0cf43ca
Compare
Owner
Author
Review remediation pushedThe final corpus-boundary review gaps are fixed and pushed at What changed:
Verification:
This update is pushed for review. No readiness or merge action was taken. |
Owner
Author
Review checkpoint — paused safelyPR #1056 remains draft at published head Two P2 findings remain:
Focused Cargo verification for the eventual fixes is still pending. This is a safe published resume point; do not mark ready or merge yet. |
This was referenced Jul 13, 2026
…22-corpus-boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1054
Refs #958
Refs #922
Refs #899
CodeStory's release evaluator previously imported the packet benchmark and its checked evaluation/query corpus transitively. That made release-control code depend on proof-only data and left non-Rust product and release surfaces outside the corpus-boundary guard.
Outcome
Release-control code now uses a corpus-neutral provenance module. The generalization guard protects the repository-controlled non-Rust product and release boundary, including shipped plugin guidance, setup/install tooling, runtime configuration, and release automation.
The exact integrated head is
58e75f3ed0089eb7e57dfe83b8e0574570ab5bfb. It merges currentdev/codestory-nextatcea5aa3975641280d9c42ee8e6d29cc1e88d2697while preserving the accepted corpus-guard fix at0cd9b9ae3a84c74cdb56190bfca31660c7b7bfb7.What changed
scripts/codestory-evidence-provenance.mjsmodule. The benchmark driver keeps its public exports, while the release evaluator imports the neutral module directly.How to review
scripts/codestory-evidence-provenance.mjsand its two callers to confirm the extraction preserved provenance behavior without importing the benchmark corpus.scripts/lint-retrieval-generalization.mjs.regexOccurrencesand compact occurrences throughcompactMarkerOccurrences; the allowance must attach only to the exact approved use.linter_binds_policy_allowances_to_the_exact_approved_useand the portable hostile fixture table.Verification
Exact integrated head
58e75f3e:cargo fmt --all -- --check— passedcargo test --locked -p codestory-runtime --test retrieval_generalization_guard— 17 passednode scripts/lint-retrieval-generalization.mjs— passed; 73 protected non-Rust files and 1,433 patternsnode .github/scripts/check-workflow-policy.mjs— passednode .github/scripts/route-ci-proof.mjs --self-test— passedgit diff --check origin/dev/codestory-next...HEAD— passedEarlier implementation proof, before the focused review fixes:
cargo check --workspace --locked,cargo test --workspace --locked, all-target/all-feature clippy with warnings denied, and the release CLI build — passed at0131b97node --test scripts/tests/*.test.mjs— 125 passednode --test plugins/codestory/tests/plugin-static.test.mjs— 71 passed, 1 platform skip9c97808a+1054wt— full-sidecar pass, 148,577 nodes, 123,886 edges, 308 files, 0 errorsThe stats lane used explicit CPU allowance and emitted the expected living-baseline warning: retrieval indexing took 66.14 seconds versus the 19.23-second warning threshold. This row is telemetry, not baseline-promotion evidence.
Risk and follow-up
The guard is intentionally static. It does not claim to prove arbitrary runtime-generated strings, environment/generated bytes, or external-process internals; existing attestation and runtime checks remain responsible for those boundaries. This PR does not change release activation, baseline selection, or timing thresholds under #958.