Replace softprops/action-gh-release with direct GH api create release…#304
Merged
dbernstein merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
io7m
requested changes
Apr 14, 2026
Contributor
io7m
left a comment
io7m
left a comment
There was a problem hiding this comment.
GitHub seems unhappy with this. Comes up with an error in the YAML viewer.
| uses: softprops/action-gh-release@v2 | ||
| - name: Create or update release | ||
| env: | ||
| GITHUB_TOKEN: ${{ GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
I think that should be secrets.CI_GITHUB_ACCESS_TOKEN.
Contributor
Author
There was a problem hiding this comment.
yeah - I wasn't sure since ios-core wasn't using it. But it's probably better to go with the ci token.
io7m
approved these changes
Apr 14, 2026
Contributor
io7m
left a comment
io7m
left a comment
There was a problem hiding this comment.
It seems happy with that. 🚀
dbernstein
deleted the
replace-softprops-action-with-direct-release-gh-api-calls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… call
Why are we doing this? (w/ JIRA link if applicable)
We're trying to get the jira-release-sync workflow to trigger on a "publish" event.
How should this be tested? / Do these changes have associated tests?
Should be tested during next release.
Dependencies for merging? Releasing to production?
No.
Did someone actually run this code to verify it works?
Not yet: but it was taken from ios-core where it has run successfully.