Skip to content

Replace softprops/action-gh-release with direct GH api create release… #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbernstein merged 2 commits into from
Apr 14, 2026
Merged

Replace softprops/action-gh-release with direct GH api create release… #304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c9cb2
Replace softprops/action-gh-release with direct GH api create release…
dbernstein Apr 14, 2026
f57bc08
Use secrets.CI_GITHUB_ACCESS_TOKEN
dbernstein Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/android-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,15 @@ jobs:
run: .ci/ci-verify-release-branch.sh
- name: Finish release
run: .ci/ci-release-finish.sh
- name: Create GitHub release
uses: softprops/action-gh-release@v2
- name: Create or update release
env:
GITHUB_TOKEN: ${{ GITHUB_TOKEN }}
Copy link
Copy Markdown
Contributor

@io7m io7m Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be secrets.CI_GITHUB_ACCESS_TOKEN.

Copy link
Copy Markdown
Contributor Author

@dbernstein dbernstein Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - I wasn't sure since ios-core wasn't using it. But it's probably better to go with the ci token.

RELEASE_NOTES_PATH: ${{ env.RELEASE_NOTES_PATH }}
TAG_NAME: ${{ env.TAG_NAME }}
VERSION_NUM: ${{ env.VERSION_NUM }}
with:
token: ${{ secrets.CI_GITHUB_ACCESS_TOKEN }}
tag_name: ${{ env.TAG_NAME }}
name: ${{ env.VERSION_NUM }}
body_path: ${{ env.RELEASE_NOTES_PATH }}
draft: false
run: |
gh release create "$VERSION_NUM" \
--title "$VERSION_NUM" \
--notes-file "$RELEASE_NOTES_PATH"
- name: Build
env:
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
Expand Down
Loading