Repository navigation
Show StepForge in French, Spanish, Russian, Simplified Chinese or Japanese, chosen in Settings → General - #186
Merged
Merged
Conversation
…languages in the Store package
…nese and Japanese, marked Beta in Settings
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Relates to #178 (point 2, translations). Stacked on #179: the base is
feat/178-microsoft-store, so the Store package can declare the new languages. Merge #179 first and GitHub retargets this PR tomain.Summary
StepForge's interface now comes in English, French, Spanish, Russian, Simplified Chinese and Japanese. It follows the system language by default. Settings → General → Language (the last card on the page) picks a different one, and StepForge reloads its window in that language after saving the open guide. Every language except English is marked Beta in the picker. Exported guides stay in English.
The Microsoft Store package now lists all six languages, so the Store shows StepForge as available in them and Partner Center offers a listing for each one.
Changes
core/i18n.jsis shared by the main process and the sandboxed renderer, which loads it with a script tag.t('Settings'),t('Move to {folder}', { folder }), andtn(count, '{count} step', '{count} steps')for plurals, usingIntl.PluralRules. Russian has one, few and many forms.core/locales/<code>.js.settings.languagedefaults to'system'; it was an unused'en'before.app.getPreferredSystemLanguages(), then loadsindex.html?lang=<code>.fr-CAmaps to French. Traditional Chinese locales fall back to English.app:setLanguagevalidates the choice, saves it and reloads the window when the shown language changes.settings:setnow refuses thelanguagekey.scripts/package-windows-store.jstakesappx.languagesfromLANGUAGES(en-US first, as the default).npm run translations(scripts/check-translations.js) lists text each catalog is missing and placeholder mismatches.tests/unit/i18n.test.jscovers locale matching, fallback, plurals, catalog completeness and placeholders, and the renderer bootstrap. Renderer UI tests get the translator through arendererI18n()helper. Two source-matching tests were updated for the wrapped labels.Area
Testing
npm test: 1050 passed, 0 failed, 20 skipped.npm run translations: 732 of 732 in every language.tests/checks/test_repo_structure.shpasses.bash tests/run_test.shnot run (it launches the app).Screenshots or recordings
N/A
Rollout notes
language: 'en', so current installs stay in English. New installs follow the system language.Checklist