Media: Restore accessible name for media items without a title by itzmekhokan · Pull Request #12136 · WordPress/wordpress-develop

itzmekhokan · 2026-06-09T10:28:45Z

Saved attachments without a title were being announced as "uploading…" in the Media Library grid view. This restores a meaningful accessible name for them while keeping the upload-progress naming added in [62104].

What the problem was:

[62104] (follow-up to #64883) set the grid item aria-label to title || 'uploading…' so in-progress uploads get an accessible name.
That fallback also matched any saved attachment with no title, so every titleless image was announced as "uploading…".

What the fix does:

Limits the "uploading…" fallback to items that are actually uploading.
Falls back to the existing "(no title)" string for saved attachments that have no title.

Approach and why:

A simple swap of "uploading…" → "(no title)" (per comment:1) would re-break #64883, since real uploads have no title yet. Gating on the model's uploading flag satisfies both tickets.
Both "uploading…" and "(no title)" already exist as translatable core strings, so no new strings are introduced.

Testing instructions:

In the Media Library, ensure you have an image with no Title set.
Open the grid view (Media → Library, grid mode) and inspect the image tile: its <li class="attachment"> aria-label should read "(no title)" (verify with a screen reader or the browser a11y inspector), not "uploading…".
Upload a new file and, while it is uploading, confirm its tile's aria-label still reads "uploading…".
Confirm an image that has a title is unchanged (announced by its title).

Trac ticket: https://core.trac.wordpress.org/ticket/65438

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Ticket and regression analysis (tracing the cause to [62104]) and drafting the one-line fix. All changes were reviewed, validated against the codebase, and are taken responsibility for by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Changeset [62104] added an "uploading…" fallback for the grid item `aria-label` so that in-progress uploads, which have no title yet, get an accessible name. That fallback also matched saved attachments that simply have no title, so every titleless image was announced as "uploading…" in the Media Library grid view. Limit the "uploading…" fallback to items that are actually uploading, and fall back to the existing "(no title)" string for saved attachments without a title. Both strings already exist in core, so no new translatable strings are introduced. Follow-up to [62104]. Fixes #65438. See #64883.

github-actions · 2026-06-09T10:28:55Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar, joedolson, cbravobernal, ankitkumarshah, masteradhoc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-06-09T10:33:39Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Infinite-Null · 2026-06-10T16:02:25Z

Hi @itzmekhokan,
Tested this PR and can see that it successfully resolves the issue.

I verified that media items without a title are now listed as "(no title)" instead of "uploading…" in the Media Library grid view. Media items with titles remain unaffected.

Screenshot attached for reference.

Before:

After

masteradhoc · 2026-06-23T18:57:12Z

Thanks for the PR @itzmekhokan. I can confirm this PR works as expected and the results are as @Infinite-Null showed them in the comment above. LGTM

Build the aria-label value with an explicit if/else block instead of a nested ternary for readability. See #65438.

masteradhoc · 2026-06-30T14:41:39Z

The Adjustment didnt work out for me. When the upload finished and the media library page is refreshed its again saying "uploading..."

itzmekhokan · 2026-06-30T15:00:23Z

The Adjustment didnt work out for me. When the upload finished and the media library page is refreshed its again saying "uploading..."

Thanks for testing! This change lives in the source module src/js/media/views/attachment.js, but the Media Library loads the compiled wp-includes/js/media-views.js bundle (a gitignored build artifact, so it's not in the diff). Until that's rebuilt, your site keeps serving the old title || 'uploading…' line, which is why a refresh brings it back.

Please rebuild after checking out the branch:

npm install
grunt build

cbravobernal

LGTM

Changeset [62104] added an "uploading…" fallback for the grid item `aria-label` so that in-progress uploads, which have no title yet, get an accessible name. That fallback also matched saved attachments that simply have no title, so every titleless image was announced as "uploading…" in the Media Library grid view. Limit the "uploading…" fallback to items that are actually uploading, and fall back to the existing "(no title)" string for saved attachments without a title. Both strings already exist in core, so no new translatable strings are introduced. Follow-up to [62104]. Fixes #65438. See #64883.

Build the aria-label value with an explicit if/else block instead of a nested ternary for readability. See #65438.

…thub.com/itzmekhokan/wordpress-develop into pr/12136

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

joedolson

LGTM!

In the media library, the `aria-label` for an untitled image fell back to "uploading...", the string used during the upload processing. Change the values so that images only use "uploading..." during the uploading process, but otherwise use "(no title)", like other untitled items. Developed in #12136 Props jamieburchell, presskopp, khokansardar, joedolson, tusharaddweb, ankitkumarshah, chillifish, masteradhoc, cbravobernal. Fixes #65438, see #64883. git-svn-id: https://develop.svn.wordpress.org/trunk@62892 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-07-29T01:37:16Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62892
GitHub commit: d99627d

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

In the media library, the `aria-label` for an untitled image fell back to "uploading...", the string used during the upload processing. Change the values so that images only use "uploading..." during the uploading process, but otherwise use "(no title)", like other untitled items. Developed in WordPress/wordpress-develop#12136 Props jamieburchell, presskopp, khokansardar, joedolson, tusharaddweb, ankitkumarshah, chillifish, masteradhoc, cbravobernal. Fixes #65438, see #64883. Built from https://develop.svn.wordpress.org/trunk@62892 git-svn-id: http://core.svn.wordpress.org/trunk@62159 1a063a9b-81f0-0310-95a4-ce76da25c4cd

cbravobernal requested a review from joedolson June 30, 2026 10:28

cbravobernal requested changes Jun 30, 2026

View reviewed changes

Comment thread src/js/media/views/attachment.js Outdated

Media: Avoid nested ternary when building attachment aria-label.

daf1a30

Build the aria-label value with an explicit if/else block instead of a nested ternary for readability. See #65438.

itzmekhokan requested a review from cbravobernal June 30, 2026 10:42

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

Merge remote-tracking branch 'upstream/trunk' into pr/12136

0ac207f

cbravobernal approved these changes Jul 14, 2026

View reviewed changes

itzmekhokan added 2 commits July 14, 2026 10:56

Media: Avoid nested ternary when building attachment aria-label.

da16e3d

Build the aria-label value with an explicit if/else block instead of a nested ternary for readability. See #65438.

cbravobernal force-pushed the fix/65438-media-grid-no-title-aria-label branch from 0ac207f to da16e3d Compare July 14, 2026 08:56

joedolson added 2 commits July 28, 2026 19:38

Merge branch 'fix/65438-media-grid-no-title-aria-label' of https://gi…

9984afa

…thub.com/itzmekhokan/wordpress-develop into pr/12136

Merge branch 'trunk' into pr/12136

7c861a2

Copilot AI review requested due to automatic review settings July 29, 2026 00:40

Copilot AI reviewed Jul 29, 2026

joedolson approved these changes Jul 29, 2026

View reviewed changes

github-actions Bot closed this Jul 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Media: Restore accessible name for media items without a title - #12136

Media: Restore accessible name for media items without a title#12136
itzmekhokan wants to merge 7 commits into
WordPress:trunkfrom
itzmekhokan:fix/65438-media-grid-no-title-aria-label

itzmekhokan commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

Infinite-Null commented Jun 10, 2026

Uh oh!

masteradhoc commented Jun 23, 2026

Uh oh!

Uh oh!

masteradhoc commented Jun 30, 2026

Uh oh!

itzmekhokan commented Jun 30, 2026

Uh oh!

cbravobernal left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

joedolson left a comment

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

itzmekhokan commented Jun 9, 2026

Use of AI Tools

Uh oh!

github-actions Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Infinite-Null commented Jun 10, 2026

Uh oh!

masteradhoc commented Jun 23, 2026

Uh oh!

Uh oh!

masteradhoc commented Jun 30, 2026

Uh oh!

itzmekhokan commented Jun 30, 2026

Uh oh!

cbravobernal left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

joedolson left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Jun 9, 2026 •

edited

Loading