Skip to content

Media: Restore accessible name for media items without a title #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itzmekhokan wants to merge 7 commits into from
Closed

Media: Restore accessible name for media items without a title #12136

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e827f99
Media: Restore accessible name for media items without a title.
itzmekhokan Jun 9, 2026
daf1a30
Media: Avoid nested ternary when building attachment aria-label.
itzmekhokan Jun 30, 2026
0ac207f
Merge remote-tracking branch 'upstream/trunk' into pr/12136
joedolson Jul 12, 2026
49ed75a
Media: Restore accessible name for media items without a title.
itzmekhokan Jun 9, 2026
da16e3d
Media: Avoid nested ternary when building attachment aria-label.
itzmekhokan Jun 30, 2026
9984afa
Merge branch 'fix/65438-media-grid-no-title-aria-label' of https://gi…
joedolson Jul 29, 2026
7c861a2
Merge branch 'trunk' into pr/12136
joedolson Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/js/media/views/attachment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,20 @@ Attachment = View.extend(/** @lends wp.media.view.Attachment.prototype */{
template: wp.template('attachment'),

attributes: function() {
var ariaLabel = this.model.get( 'title' );

if ( ! ariaLabel ) {
if ( this.model.get( 'uploading' ) ) {
ariaLabel = wp.i18n.__( 'uploading…' );
} else {
ariaLabel = wp.i18n.__( '(no title)' );
}
}

return {
'tabIndex': 0,
'role': 'checkbox',
'aria-label': this.model.get( 'title' ) || wp.i18n.__( 'uploading…' ),
'aria-label': ariaLabel,
'aria-checked': false,
'data-id': this.model.get( 'id' )
};
Expand Down
Loading