Theme browser: prevent previous navigation on first theme. - #12696
Theme browser: prevent previous navigation on first theme.#12696afercia wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
Prevents unintended “wrap-around” behavior in the Theme Browser overlay when navigating to the previous theme while already on the first theme in the collection.
Changes:
- Adds an early return in the
previous()navigation handler when the current theme is at index0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
aff6e44 to
04fcd03
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/js/_enqueues/wp/theme.js:1350
indexis already computed a few lines above; reusing it here avoids a redundantindexOf()call and guarantees the same index is used for the boundary check and lookup.
previousModel = self.collection.at( self.collection.indexOf( model ) - 1 );
…e browser. Prevents unintended 'wrap-around' behavior in the Theme browser overlay when navigating to the previous theme while already on the first theme in the collection. The navigation now stops at the first theme. This is consistent with the navigation to the next theme, which stops at the last theme. Developed in #12696 Props joedolson, afercia. Fixes #65715. git-svn-id: https://develop.svn.wordpress.org/trunk@62869 602fd350-edb4-49c9-b593-d223f7449a82
…e browser. Prevents unintended 'wrap-around' behavior in the Theme browser overlay when navigating to the previous theme while already on the first theme in the collection. The navigation now stops at the first theme. This is consistent with the navigation to the next theme, which stops at the last theme. Developed in WordPress/wordpress-develop#12696 Props joedolson, afercia. Fixes #65715. Built from https://develop.svn.wordpress.org/trunk@62869 git-svn-id: http://core.svn.wordpress.org/trunk@62148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Trac ticket: https://core.trac.wordpress.org/ticket/65715
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.