Skip to content

Theme browser: prevent previous navigation on first theme. #12696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afercia wants to merge 3 commits into from
+10 −2
Closed

Theme browser: prevent previous navigation on first theme. #12696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd87d07
Theme browser: prevent previous navigation on first theme.
afercia Jul 26, 2026
04fcd03
Apply Copilot feedback.
afercia Jul 28, 2026
434efa7
Reuse the computed index.
afercia Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/js/_enqueues/wp/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,12 +1334,20 @@ themes.view.Themes = wp.Backbone.View.extend({
*/
previous: function( args ) {
var self = this,
model, previousModel;
model, previousModel, index;

// Get the current theme.
model = self.collection.get( args[0] );

index = self.collection.indexOf( model );

// Bail early if the current theme is the first one or the model does not exist.
if ( index <= 0 ) {
return;
}

// Find the previous model within the collection.
previousModel = self.collection.at( self.collection.indexOf( model ) - 1 );
previousModel = self.collection.at( index - 1 );

if ( previousModel !== undefined ) {

Expand Down
Loading