Skip to content

Plugin Dependencies: Recognize network-active dependencies - #12782

Open
benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:fix/65759-network-active-plugin-dependencies
Open

Plugin Dependencies: Recognize network-active dependencies#12782
benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:fix/65759-network-active-plugin-dependencies

Conversation

@benitoalba

Copy link
Copy Markdown

Summary

wp_get_plugin_action_button() only checked the per-site active_plugins option when determining whether plugin dependencies were active. On multisite, this caused the Activate button to remain disabled when a dependency was network-active.

This changes the dependency check to use is_plugin_active(), which recognizes both per-site and network activation, and adds a multisite regression test.

Trac ticket: https://core.trac.wordpress.org/ticket/65759

Testing

  • Focused multisite regression test: 1 test, 3 assertions
  • Complete action-button test class on multisite: 3 tests, 7 assertions
  • Complete action-button test class on single site: 3 tests, 6 assertions
  • PHP coding standards on both changed files
  • git diff --check

Use of AI Tools

AI assistance: Codex assisted with drafting the code and tests. I reviewed and validated the changes and completed the remaining contribution work.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@benitoalba
benitoalba marked this pull request as ready for review July 31, 2026 01:53
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props benitoalba.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant