Skip to content

Plugin Dependencies: Recognize network-active dependencies #12782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benitoalba wants to merge 1 commit into
base: trunk
Choose a base branch
from
+63 −9
Open

Plugin Dependencies: Recognize network-active dependencies #12782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/wp-admin/includes/plugin-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,20 +914,17 @@ function wp_get_plugin_action_button( $name, $data, $compatible_php, $compatible

// Determine the status of plugin dependencies.
$installed_plugins = get_plugins();
$active_plugins = get_option( 'active_plugins', array() );
$plugin_dependencies_count = count( $requires_plugins );
$installed_plugin_dependencies_count = 0;
$active_plugin_dependencies_count = 0;
foreach ( $requires_plugins as $dependency ) {
foreach ( array_keys( $installed_plugins ) as $installed_plugin_file ) {
if ( str_contains( $installed_plugin_file, '/' ) && explode( '/', $installed_plugin_file )[0] === $dependency ) {
++$installed_plugin_dependencies_count;
}
}

foreach ( $active_plugins as $active_plugin_file ) {
if ( str_contains( $active_plugin_file, '/' ) && explode( '/', $active_plugin_file )[0] === $dependency ) {
++$active_plugin_dependencies_count;
if ( is_plugin_active( $installed_plugin_file ) ) {
++$active_plugin_dependencies_count;
}
}
}
}
Expand Down
63 changes: 60 additions & 3 deletions tests/phpunit/tests/admin/includes/plugin-install/WpGetPluginActionButton_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ class Admin_Includes_Plugin_Install_WpGetPluginActionButton_Test extends WP_Unit
*/
private static $test_plugin;

/**
* Test dependency plugin data.
*
* @var stdClass
*/
private static $dependency_plugin;

/**
* Sets up properties and adds a test plugin before any tests run.
*/
Expand All @@ -42,19 +49,33 @@ public static function set_up_before_class() {
$role_name = 'wp_get_plugin_action_button-test-role';
add_role( $role_name, 'Test Role' );

self::$role = get_role( $role_name );
self::$user_id = self::factory()->user->create( array( 'role' => $role_name ) );
self::$test_plugin = (object) array(
self::$role = get_role( $role_name );
self::$user_id = self::factory()->user->create( array( 'role' => $role_name ) );
self::$test_plugin = (object) array(
'name' => 'My Plugin',
'slug' => 'my-plugin',
'version' => '1.0.0',
);
self::$dependency_plugin = (object) array(
'name' => 'My Dependency Plugin',
'slug' => 'my-dependency-plugin',
'version' => '1.0.0',
'file' => 'my-dependency-plugin/my_dependency_plugin.php',
);

mkdir( WP_PLUGIN_DIR . '/' . self::$test_plugin->slug );
file_put_contents(
WP_PLUGIN_DIR . '/' . self::$test_plugin->slug . '/my_plugin.php',
"<?php\n/**\n* Plugin Name: " . self::$test_plugin->name . "\n* Version: " . self::$test_plugin->version . "\n*/"
);

mkdir( WP_PLUGIN_DIR . '/' . self::$dependency_plugin->slug );
file_put_contents(
WP_PLUGIN_DIR . '/' . self::$dependency_plugin->file,
"<?php\n/**\n* Plugin Name: " . self::$dependency_plugin->name . "\n* Version: " . self::$dependency_plugin->version . "\n*/"
);

wp_clean_plugins_cache( false );
}

/**
Expand All @@ -67,6 +88,11 @@ public static function tear_down_after_class() {

unlink( WP_PLUGIN_DIR . '/' . self::$test_plugin->slug . '/my_plugin.php' );
rmdir( WP_PLUGIN_DIR . '/' . self::$test_plugin->slug );

unlink( WP_PLUGIN_DIR . '/' . self::$dependency_plugin->file );
rmdir( WP_PLUGIN_DIR . '/' . self::$dependency_plugin->slug );

wp_clean_plugins_cache( false );
}

/**
Expand Down Expand Up @@ -152,4 +178,35 @@ public function test_should_not_return_empty_string_with_proper_capabilities_mul
$this->assertIsString( $actual, 'A string should be returned.' );
$this->assertNotEmpty( $actual, 'An empty string should not be returned.' );
}

/**
* Tests that the Activate button is enabled when a dependency is network-active.
*
* @ticket 65759
*
* @group ms-required
*/
public function test_should_enable_activate_button_when_dependency_is_network_active() {
$test_plugin = clone self::$test_plugin;
$test_plugin->requires_plugins = array( self::$dependency_plugin->slug );

wp_set_current_user( self::$user_id );
grant_super_admin( self::$user_id );

$activation_result = activate_plugin( self::$dependency_plugin->file, '', true );

$actual = wp_get_plugin_action_button(
$test_plugin->name,
$test_plugin,
true,
true
);

deactivate_plugins( self::$dependency_plugin->file, true, true );
revoke_super_admin( self::$user_id );

$this->assertNull( $activation_result, 'The dependency plugin should be network-activated.' );
$this->assertStringContainsString( 'activate-now', $actual, 'An enabled Activate button should be returned.' );
$this->assertStringNotContainsString( 'button-disabled', $actual, 'The Activate button should not be disabled.' );
}
}
Loading