feat(menu-bar): add copy last transcript action#450
Open
matthewrball wants to merge 2 commits into
Open
Conversation
matthewrball
changed the title
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Copy Last Transcriptitem directly under the menu bar status row (Ready to Record...) so users can copy the most recent saved dictation without opening the main window or overlay actions menu.What changed
MenuBarManagerimmediately below the status item.Validation
git diff --checkplutil -lint Fluid.xcodeproj/project.pbxproj Info.plist Fluid.entitlementsxcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64' -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testTranscriptionHistoryEntryClipboardTextPrefersProcessedText -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testTranscriptionHistoryEntryClipboardTextFallsBackToRawText -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testTranscriptionHistoryEntryClipboardTextSkipsEmptyText CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NOxcodebuild build -project Fluid.xcodeproj -scheme Fluid -configuration Debug -destination 'platform=macOS,arch=arm64' CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO