Skip to content

docs(skills): agent-executable follow-up comments in td-pr-contributor-review#515

Closed
cidrblock wants to merge 1 commit into
ansible:mainfrom
cidrblock:docs/agent-executable-contributor-review-comments
Closed

docs(skills): agent-executable follow-up comments in td-pr-contributor-review#515
cidrblock wants to merge 1 commit into
ansible:mainfrom
cidrblock:docs/agent-executable-contributor-review-comments

Conversation

@cidrblock

Copy link
Copy Markdown
Contributor

Summary

Extend td-pr-contributor-review (v1.2.0) with guidance for writing agent-executable maintainer comments when a contributor PR needs work and another session (human or agent) will land the fixes.

Motivated by the follow-up brief pattern used on redhat-developer/abbenay#83: a single ordered comment with P0/P1 items, problem/why/what/acceptance per item, explicit non-goals, verification commands, and a done definition — so the next agent does not re-derive intent from chat.

Changes

  • New section 5c. Agent-executable follow-up comments
    • When to post vs fix in-session vs file an issue (ties to existing 5b)
    • Required comment structure (context → how to use → P0 → P1 → out of scope → verification → done definition)
    • Per-item template: Problem / Why it matters / What to do / Acceptance
    • Writing rules, copy-paste skeleton, anti-patterns
  • Checklist + skill description updated; version 1.1.0 → 1.2.0

Test plan

  • tox -e lint (prek / codespell / etc.)
  • Skim section 5c for clarity as an executing agent
  • After merge: confirm sync_skills (or equivalent) picks up the skill for downstream repos

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Label error. Requires at least 1 of: breaking, chore, feat, fix. Found: docs. Follow https://www.conventionalcommits.org to get auto-labeling to work correctly.

…or-review

Teach maintainers to leave a single P0/P1 brief (problem, why, what,
acceptance, non-goals, verification, done definition) so another agent can
execute review follow-ups without re-deriving intent from chat.
@cidrblock
cidrblock force-pushed the docs/agent-executable-contributor-review-comments branch from 013e927 to c79b1c2 Compare July 20, 2026 15:23
@cidrblock

Copy link
Copy Markdown
Contributor Author

Moved to a same-repo PR so CI can use BOT_PAT for the lint checkout (fork PRs leave that secret empty → actions/checkout fails with “token required”).

Superseded by: will fill after create

@cidrblock

Copy link
Copy Markdown
Contributor Author

Moved to a same-repo PR so CI can use BOT_PAT for the lint checkout (fork PRs leave that secret empty → actions/checkout fails with “token required”).

Superseded by: #516

@cidrblock

Copy link
Copy Markdown
Contributor Author

Superseded by same-repo PR #516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants