Skip to content

chore(skills): agent-executable follow-up comments in td-pr-contributor-review#516

Merged
cidrblock merged 1 commit into
mainfrom
docs/agent-executable-contributor-review-comments
Jul 20, 2026
Merged

chore(skills): agent-executable follow-up comments in td-pr-contributor-review#516
cidrblock merged 1 commit into
mainfrom
docs/agent-executable-contributor-review-comments

Conversation

@cidrblock

Copy link
Copy Markdown
Contributor

Summary

Extend td-pr-contributor-review (v1.2.0) with guidance for writing agent-executable maintainer comments when a contributor PR needs work and another session (human or agent) will land the fixes.

Motivated by the follow-up brief pattern used on redhat-developer/abbenay#83: a single ordered comment with P0/P1 items, problem/why/what/acceptance per item, explicit non-goals, verification commands, and a done definition — so the next agent does not re-derive intent from chat.

Supersedes the fork-based PR #515 (same change; reopened as a same-repo PR so lint can use BOT_PAT).

Changes

  • New section 5c. Agent-executable follow-up comments
    • When to post vs fix in-session vs file an issue (ties to existing 5b)
    • Required comment structure (context → how to use → P0 → P1 → out of scope → verification → done definition)
    • Per-item template: Problem / Why it matters / What to do / Acceptance
    • Writing rules, copy-paste skeleton, anti-patterns
  • Checklist + skill description updated; version 1.1.0 → 1.2.0

Test plan

  • tox -e lint (prek / codespell / etc.)
  • CI green on same-repo PR (lint with BOT_PAT, ack with chore label)
  • Skim section 5c for clarity as an executing agent
  • After merge: confirm skill sync picks this up for downstream repos

…or-review

Teach maintainers to leave a single P0/P1 brief (problem, why, what,
acceptance, non-goals, verification, done definition) so another agent can
execute review follow-ups without re-deriving intent from chat.
@cidrblock
cidrblock merged commit 40935f1 into main Jul 20, 2026
20 of 23 checks passed
@cidrblock
cidrblock deleted the docs/agent-executable-contributor-review-comments branch July 20, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants