Fix count-min sketches test snapshots should use binary mode#505
Fix count-min sketches test snapshots should use binary mode#505tisonkun wants to merge 2 commits into
Conversation
Signed-off-by: tison <wander4096@gmail.com>
|
Seems other snapshot generations already use binary mode. |
There was a problem hiding this comment.
Pull request overview
This PR ensures Count-Min sketch test snapshot files are written in binary mode so serialized output is consistent across platforms (notably avoiding CRLF translation on Windows).
Changes:
- Open snapshot
std::ofstreamstreams withstd::ios::binaryfor the empty and non-empty serialization tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
since it looks like all the other files end with ".sk" , only count min with |
Coverage Report for CI Build 28152728714Coverage remained the same at 82.199%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Good point. As other impls may also depend on the name, I'd sync with @leerho @proost @freakyzoidberg first to make the unify if any. |
I agree with this. I can update it in this PR or do it in a follow-up. One possible impact is that datasketches-java and datasketches-go, IIRC, test against these snapshot files. So they may be affected by the name changes as well. But for sure we can update there cascadingly, just need to inform all the related devs. |
Signed-off-by: tison <wander4096@gmail.com>
|
Pushed 7c993ed for the rename. I'm going to merge this patch later today or tomorrow and fix any impact downstream. |
... otherwise
\nwould be\r\non Windows and cause apache/datasketches-rust#92 to fail.