Skip to content

Fix count-min sketches test snapshots should use binary mode #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tisonkun wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix count-min sketches test snapshots should use binary mode #505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af44362
Fix count-min sketches test snapshots should use binary mode
tisonkun Jun 24, 2026
7c993ed
Unify snapshot test files name
tisonkun Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions count/test/count_min_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize empty", "[cm_sketch]") {
for (auto di: d) {
REQUIRE(di == 0);
}
std::ofstream os("count_min-empty.bin");
std::ofstream os("count_min_empty_cpp.sk", std::ios::binary);
c.serialize(os);
}

Expand Down Expand Up @@ -243,7 +243,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize non-empty", "[cm_sketch]") {
++d_it;
}

std::ofstream os("count_min-non-empty.bin");
std::ofstream os("count_min_non_empty_cpp.sk", std::ios::binary);
c.serialize(os);
}

Expand Down
Loading