Skip to content

[Studio] Validate alert rule action requests - #549

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-alert-rule-validation
Closed

[Studio] Validate alert rule action requests#549
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-alert-rule-validation

Conversation

@Aias00

@Aias00 Aias00 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • replace alert rule toggle/delete map parsing with typed request DTOs
  • validate required rule ids and enabled state before invoking alert operations
  • return structured 400 responses for missing ids, missing enabled values, and invalid enabled JSON types

Scope

  • RocketMQ Studio contest scope: Track 1 / METRICS-01 alert rule action hardening
  • Does not introduce Namespace behavior

Tests

  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test
  • git diff --check

Copilot AI review requested due to automatic review settings July 24, 2026 12:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #632. Consolidated with related ops request validation changes to reduce review overhead while preserving the same scoped fixes and tests.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants