Skip to content

[Studio] Cover metrics query request validation - #576

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:test/studio-metrics-controller-validation
Closed

[Studio] Cover metrics query request validation#576
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:test/studio-metrics-controller-validation

Conversation

@Aias00

@Aias00 Aias00 commented Jul 25, 2026

Copy link
Copy Markdown

Summary

  • add MetricsController coverage for blank PromQL expressions, non-positive start timestamps, and blank query steps
  • assert invalid requests return 400 before reaching the metrics service

Validation

  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=MetricsControllerTest test
  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test (50 surefire files, 296 tests, 0 failures, 0 errors)
  • git diff --check

Copilot AI review requested due to automatic review settings July 25, 2026 05:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #637. Consolidated with related Metrics/Prometheus validation changes to reduce review overhead while preserving the same scoped fixes and tests.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants