Skip to content

[Studio] Cover metrics query request validation #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aias00 wants to merge 1 commit into from
Closed

[Studio] Cover metrics query request validation #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions server/src/test/java/com/rocketmq/studio/cluster/metrics/MetricsControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,48 @@ class MetricsControllerTest {
@MockBean
private MetricsService metricsService;

@Test
void queryShouldReturnBadRequestWhenMetricIsBlank() throws Exception {
mockMvc.perform(post("/api/metrics/query")
.contentType(MediaType.APPLICATION_JSON)
.content("""
{"metric":" ","start":1784107658,"end":1784108558,"step":"30s"}
"""))
.andExpect(status().isBadRequest())
.andExpect(jsonPath("$.code").value(400))
.andExpect(jsonPath("$.message").value("Metric query is required"));

verifyNoInteractions(metricsService);
}

@Test
void queryShouldReturnBadRequestWhenStartIsNotPositive() throws Exception {
mockMvc.perform(post("/api/metrics/query")
.contentType(MediaType.APPLICATION_JSON)
.content("""
{"metric":"up","start":0,"end":1784108558,"step":"30s"}
"""))
.andExpect(status().isBadRequest())
.andExpect(jsonPath("$.code").value(400))
.andExpect(jsonPath("$.message").value("Metric query start must be positive"));

verifyNoInteractions(metricsService);
}

@Test
void queryShouldReturnBadRequestWhenStepIsBlank() throws Exception {
mockMvc.perform(post("/api/metrics/query")
.contentType(MediaType.APPLICATION_JSON)
.content("""
{"metric":"up","start":1784107658,"end":1784108558,"step":""}
"""))
.andExpect(status().isBadRequest())
.andExpect(jsonPath("$.code").value(400))
.andExpect(jsonPath("$.message").value("Metric query step is required"));

verifyNoInteractions(metricsService);
}

@Test
void queryShouldReturnBadRequestWhenFieldTypeIsInvalid() throws Exception {
mockMvc.perform(post("/api/metrics/query")
Expand Down
Loading