Skip to content

fix(local-dev): Extend lakekeeper setup for windows - #7141

Open
Mrudhulraj wants to merge 1 commit into
apache:mainfrom
Mrudhulraj:fix/windows-setup
Open

fix(local-dev): Extend lakekeeper setup for windows#7141
Mrudhulraj wants to merge 1 commit into
apache:mainfrom
Mrudhulraj:fix/windows-setup

Conversation

@Mrudhulraj

@Mrudhulraj Mrudhulraj commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

  • Added a dedicated helper function _detect_host_lan_ip_windows() to parse the primary non-loopback IPv4 address on Windows environments using ipconfig.

  • Handled Windows-specific output formatting by stripping trailing carriage returns (\r) and extra whitespace from ipconfig output.

  • Updated _detect_host_lan_ip() to recognize Windows kernel and shell environments (MINGW*, MSYS*, CYGWIN*, _NT) via uname -s and route them to _detect_host_lan_ip_windows().

Any related issues, documentation, discussions?

Fixes: #7138
IP resolution failures when running scripts on Windows host systems (e.g., Git Bash, MSYS2, or Cygwin).

Improves cross-platform parity between macOS (Darwin), Linux, and Windows for container/host networking setup.

How was this PR tested?

Verified manually. Attaching a screenshot.
Ran the test_local_dev_sh.sh script to verify.
image

Was this PR authored or co-authored using generative AI tooling?

No, AI usage reused the existing Darwin method to resolve it.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Yicong-Huang
    You can notify them by mentioning @Yicong-Huang in a comment.

@Mrudhulraj Mrudhulraj changed the title Extend lakekeeper setup for windows fix(local-dev): Extend lakekeeper setup for windows Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch Analysis
⚠️ release/v1.2 Not labeled automatically — none of the files this PR modifies exist on this branch (bin/local-dev/main.sh). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. Please check and add release/v1.2 by hand if this fix should be backported here.

Auto-label run.

@Mrudhulraj

Copy link
Copy Markdown
Contributor Author

@Yicong-Huang would appreciate your review here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Failure: Lakekeeper-init container fails with parse error for Windows local setup.

1 participant