fix(local-dev): Extend lakekeeper setup for windows - #7141
Open
Mrudhulraj wants to merge 1 commit into
Open
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
Backport auto-label reportThis
|
Contributor
Author
|
@Yicong-Huang would appreciate your review here. |
Mrudhulraj
force-pushed
the
fix/windows-setup
branch
from
July 30, 2026 23:10
217ec77 to
4dafc4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Added a dedicated helper function _detect_host_lan_ip_windows() to parse the primary non-loopback IPv4 address on Windows environments using ipconfig.
Handled Windows-specific output formatting by stripping trailing carriage returns (\r) and extra whitespace from ipconfig output.
Updated _detect_host_lan_ip() to recognize Windows kernel and shell environments (MINGW*, MSYS*, CYGWIN*, _NT) via uname -s and route them to _detect_host_lan_ip_windows().
Any related issues, documentation, discussions?
Fixes: #7138
IP resolution failures when running scripts on Windows host systems (e.g., Git Bash, MSYS2, or Cygwin).
Improves cross-platform parity between macOS (Darwin), Linux, and Windows for container/host networking setup.
How was this PR tested?
Verified manually. Attaching a screenshot.

Ran the
test_local_dev_sh.shscript to verify.Was this PR authored or co-authored using generative AI tooling?
No, AI usage reused the existing Darwin method to resolve it.