Skip to content

fix(local-dev): Extend lakekeeper setup for windows #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mrudhulraj wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(local-dev): Extend lakekeeper setup for windows #7141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bin/local-dev/main.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,15 @@ fi
# Both platform probes follow the same two steps: the interface backing the
# default route first (most reliable on a laptop that may have wifi +
# thunderbolt + tailscale all active), then a scan as a fallback.
_detect_host_lan_ip_windows() {
local ip=""
ip=$(ipconfig 2>/dev/null | grep -i "IPv4" | head -n 1 | awk -F: '{print $2}' | tr -d '[:space:]' | tr -d '\r')
if [[ -n "$ip" && "$ip" != 127.* ]]; then
printf '%s\n' "$ip"; return 0;
fi
return 1
}

_detect_host_lan_ip_darwin() {
local iface="" ip=""
iface=$(route get default 2>/dev/null | awk '/interface:/{print $2; exit}')
Expand Down Expand Up @@ -520,8 +529,9 @@ _detect_host_lan_ip() {
case "$(uname -s 2>/dev/null)" in
Darwin) _detect_host_lan_ip_darwin ;;
Linux) _detect_host_lan_ip_linux ;;
MINGW*|MSYS*|CYGWIN*|*_NT*) _detect_host_lan_ip_windows ;;
# Anything else (BSD, WSL oddities): try both rather than give up.
*) _detect_host_lan_ip_darwin || _detect_host_lan_ip_linux ;;
*) _detect_host_lan_ip_darwin || _detect_host_lan_ip_linux || _detect_host_lan_ip_windows ;;
esac
}
# Lazy resolver — called from subcommands that actually need to publish a
Expand Down
Loading