[build]: add buildkit ssh forwarding support#76
Open
saehejkang wants to merge 1 commit into
Open
Conversation
7 tasks
saehejkang
force-pushed
the
ssh-agent-access-build-commands
branch
from
b25cda7 to
74fe216
Compare
JaewonHur
reviewed
May 20, 2026
| id, path, hasPath := strings.Cut(value, "=") | ||
| id = strings.TrimSpace(id) | ||
| path = strings.TrimSpace(path) | ||
| if !hasPath && strings.HasPrefix(id, "/") { |
Contributor
There was a problem hiding this comment.
What is this for? Does docker support docker build --ssh /path/to/sock?
Contributor
Author
There was a problem hiding this comment.
It handles any case in which there is no = and it starts with /. This would be converted to id=default, path=/path/to/sock (interpreted as a socket path). I believe docker does support this, but I found online that using the explicit form of default=/path/to/sock is more clear for use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to apple/container#1472
Add support for receiving SSH forwarding configuration through build metadata and converting it into the buildkit ssh agent configuration.