Remove dead survey code from AccountStack.AskQuestions#127
Open
blsmth wants to merge 2 commits intosurvey-to-huh-v2from
Open
Remove dead survey code from AccountStack.AskQuestions#127blsmth wants to merge 2 commits intosurvey-to-huh-v2from
blsmth wants to merge 2 commits intosurvey-to-huh-v2from
Conversation
AskQuestions is never called — administrators are managed via `admins add/remove` commands which take email args directly. Replace with a no-op to drop the survey dependency from this file. Closes #119
blsmth
changed the title
Contributor
Author
|
@ipmb — Want to check if you're OK with us self-approving these survey-to-huh migration PRs to keep the project moving. Happy to wait for your review if you'd prefer, but wanted to flag it since these have been open a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surveycode fromAccountStack.AskQuestionsAskQuestionsis never called — administrators are managed viaadmins add/removecommands which take email args directlyCloses #119
Changes
stacks/account.goAskQuestionsimplementation; replace with no-op