Skip to content

Remove dead survey code from AccountStack.AskQuestions #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blsmth merged 2 commits into from
Apr 13, 2026
Merged

Remove dead survey code from AccountStack.AskQuestions #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30b6991
feat: migrate account administrators prompt from survey to huh
blsmth Mar 21, 2026
8d204ad
refactor: remove dead survey code from AccountStack.AskQuestions
blsmth Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions stacks/account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"sort"
"strings"

"github.com/AlecAivazis/survey/v2"
"github.com/apppackio/apppack/ui"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/cloudformation/types"
Expand Down Expand Up @@ -69,18 +68,10 @@ func (a *AccountStack) UpdateFromFlags(flags *pflag.FlagSet) error {
return nil
}

func (a *AccountStack) AskQuestions(_ aws.Config) error {
return ui.AskQuestions([]*ui.QuestionExtra{
{
Verbose: "Who can administer this account?",
HelpText: "A list of email addresses (one per line) who have access to manage this AppPack account. These users will be assigned a permissive IAM policy in your AWS account and should be fully trusted with any resources within ",
Question: &survey.Question{
Name: "Administrators",
Prompt: &survey.Multiline{Message: "Administrators"},
Validate: survey.Required,
},
},
}, a.Parameters)
// AskQuestions is a no-op for AccountStack — administrators are managed
// via the `admins add/remove` commands which take email args directly.
func (*AccountStack) AskQuestions(_ aws.Config) error {
return nil
}

func (*AccountStack) StackName(_ *string) *string {
Expand Down
Loading