feat: support EKS Auto Mode and Karpenter#39
Conversation
903941a to
4955f30
Compare
4955f30 to
e8b0ea0
Compare
jrgwv
left a comment
There was a problem hiding this comment.
Great feature work — EKS Auto Mode, Karpenter, ADOT, and Secrets Manager support are all valuable additions. A few issues to address before merging:
-
Base image is EOL: The new Dockerfiles use
python:3.11-slim-buster, but Debian Buster reached end-of-life. Please switch topython:3.11-slimorpython:3.11-slim-bookworm. -
Incorrect PostgreSQL volume path: In
docker-compose.ymlanddocker-compose-opentelemetry.yml, the volume mount ispostgres_data:/var/lib/postgresql@15/data. The@15is not a valid path — the official postgres:15 image uses/var/lib/postgresql/data. This will cause data persistence issues. -
Vendored cert-manager.yaml (5,388 lines): This will go stale quickly. Consider referencing the upstream manifest URL or using a Helm chart instead, with a pinned version noted in the README.
Please fix items 1 and 2 — item 3 is a suggestion. Thanks!
|
Issue #39 Description of changes: Integrates hiraken-w's EKS Auto Mode and Karpenter feature branch with the following additions and fixes: New features (from hiraken-w):
Fixes applied on top of original PR:
Testing:
Note: Users upgrading from PG 13 need to run By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. |
Issue #, if available:
N/A
Description of changes: