Feat/eks auto mode karpenter#44
Merged
Merged
Conversation
…ts Manager Merged hiraken-w's feat-auto-mode branch with the following fixes: - Resolved conflicts with main (K8s 1.34, Python 3.11-slim) - Updated all Dockerfiles from 3.11-slim-buster to 3.11-slim - Updated all eksctl templates from K8s 1.32 to 1.34 - Fixed PostgreSQL volume path (removed @15) in docker-compose files - Fixed netcat -> netcat-openbsd in Dockerfile.aws-secrets and Dockerfile.opentelemetry - Added apt cache cleanup (rm -rf /var/lib/apt/lists/*) to Dockerfiles - Upgraded Karpenter from 1.6.1 to 1.11.1 (latest stable, K8s 1.34 compatible) - Upgraded Aurora PostgreSQL from 13.12 (EOL) to 15.10 - Fixed ruff lint issues: removed unused imports, fixed star import, fixed import ordering - Removed Fargate template (replaced by Auto Mode)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| port = result.port | ||
| retries = 0 | ||
|
|
||
| logger.info(f"Trying to connect to {host}:{port} as {user}...") |
| ) | ||
| except ClientError as e: | ||
| if e.response['Error']['Code'] == 'ResourceNotFoundException': | ||
| print("The requested secret " + secret_name + " was not found") |
| # Parse the json string in secret_data and extract connectionstring | ||
| DATABASE_URL = json.loads(secret_data)['connectionstring'] | ||
|
|
||
| print("Database URL:", DATABASE_URL) |
| book.author = author | ||
| book.description = description | ||
| db.commit() | ||
| return RedirectResponse(url=f"/books/{book_id}", status_code=303) |
| book.author = author | ||
| book.description = description | ||
| db.commit() | ||
| return RedirectResponse(url=f"/books/{book_id}", status_code=303) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #39
Description of changes:
Integrates hiraken-w's EKS Auto Mode and Karpenter feature branch with the following additions and fixes:
New features (from hiraken-w):
eks/create-automode-python.yaml)eks/karpenter/)eks/opentelemetry/,server/opentelemetry/)eks/aws-secrets/,server/aws-secrets/)Fixes applied on top of original PR:
python:3.11-slim-buster(EOL) →python:3.11-slim@15bug indocker-compose.yml,docker-compose-opentelemetry.yml, andeks/deploy-db-python.yamlnetcat→netcat-openbsdinDockerfile.aws-secretsandDockerfile.opentelemetryrm -rf /var/lib/apt/lists/*apt cache cleanup to DockerfilesTesting:
podman compose(Python 3.11, PG 15, HTTP 200)eksctl create cluster --dry-runpassed on all 3 templates (mng, automode, karpenter)ruff check— all cleanbandit— no security issuesNote: Users upgrading from PG 13 need to run
docker compose down -vto clear the old volume, as PG 15 cannot read PG 13 data files.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.