[DO NOT MERGE] test: verify Codecov across all 4 submodules#6057
Closed
jam-jee wants to merge 1 commit into
Closed
[DO NOT MERGE] test: verify Codecov across all 4 submodules#6057jam-jee wants to merge 1 commit into
jam-jee wants to merge 1 commit into
Conversation
…RGE) No-op comment appended to each submodule __init__.py (core/train/serve/mlops) so all four unit-test jobs run and upload coverage. This produces 4 uploads, which finalizes the Codecov report even under the current `after_n_builds: 4` config (being fixed separately in #6056), letting us confirm the merged codecov.yml `ignore:` layer excludes test files and the project number reflects product-only coverage (~71%, not the old ~90%). Same-repo branch (fork PRs upload without PR context and error). Branch cut from current master (contains codecov.yml). Verification only.
Collaborator
Author
|
Closing — verification complete. This 4-submodule PR surfaced two CodeBuild→Codecov uploader bugs: uploads carry empty branch / pr=false (no PR association → no status) and no per-submodule flags (sessions failed to merge → collapsed to sessions=1, 3 files, 37%). Needs an uploader fix in the CI-infra buildspec (-B/-P/-F args). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends a no-op comment to each of the four submodule
__init__.pyfiles (core / train / serve / mlops) so all four unit-test jobs run and upload coverage.Why all 4
The merged
codecov.ymlcurrently hasafter_n_builds: 4(fix in flight: #6056). Codecov waits for 4 uploads before finalizing, so single-submodule PRs never get a report (seen on #6055:state=error, sessions=0). Touching all four submodules produces 4 uploads, letting the report finalize even under the current config.What this verifies
With master's
codecov.ymlapplied, once all 4 uploads land Codecov should show:ignore:list (previously ~98% of measured files were test files)Note: the CI buildspec still runs
--cov=.(the--cov=sagemakerchange is a separate internal CR), so this validates the server-sideignore:layer. If coverage lands near ~71% with 0 test files, theignore:layer is sufficient on its own.Same-repo branch (fork PRs upload without PR context and error — see closed #6054). Will be closed without merging once verified.