Skip to content

junos_commit_check: retire sickbay after batfish/batfish#9928 fix#172

Merged
dhalperi merged 1 commit into
mainfrom
spr/main/5df311f4
May 6, 2026
Merged

junos_commit_check: retire sickbay after batfish/batfish#9928 fix#172
dhalperi merged 1 commit into
mainfrom
spr/main/5df311f4

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented May 6, 2026

batfish/batfish@2dbe572 added fatalRedFlag warnings for unnormalized
prefixes in all tested contexts. Remove the sickbay entries and fix the
rejects-condition config to use split flat lines (prefix and table
separately) since Batfish doesn't parse combined flat lines.


Prompt:

https://github.com/batfish/batfish/commit/2dbe572f817bfe9e52568272a5d0cf2427a74f9d
mostly fixed junos_commit_check lab.

1. Why didn't it fix the rejects-condition-junos test? Looks like
that's in there.
2. Fix the sickbay file for the now XFAIL tests.

batfish/batfish@2dbe572 added fatalRedFlag warnings for unnormalized
prefixes in all tested contexts. Remove the sickbay entries and fix the
rejects-condition config to use split flat lines (prefix and table
separately) since Batfish doesn't parse combined flat lines.

----

Prompt:
```
batfish/batfish@2dbe572
mostly fixed junos_commit_check lab.

1. Why didn't it fix the rejects-condition-junos test? Looks like
that's in there.
2. Fix the sickbay file for the now XFAIL tests.
```

commit-id:5df311f4
@dhalperi dhalperi enabled auto-merge (squash) May 6, 2026 01:04
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (e5b5803) to head (e8cc4cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          87       87           
  Lines        4165     4165           
=======================================
  Hits         3478     3478           
  Misses        687      687           
Flag Coverage Δ
unittests 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhalperi dhalperi merged commit d548999 into main May 6, 2026
110 checks passed
@dhalperi dhalperi deleted the spr/main/5df311f4 branch May 6, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants