Skip to content

junos_commit_check: retire sickbay after batfish/batfish#9928 fix #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalperi merged 1 commit into from
May 6, 2026
Merged

junos_commit_check: retire sickbay after batfish/batfish#9928 fix #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions infra/examples/junos-commit-check/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,15 @@ checks:
- type: commit_check_rejects
node: dut
config_lines:
- "set policy-options condition TEST if-route-exists 192.168.1.111/24 table inet.0"
- "set policy-options condition TEST if-route-exists 192.168.1.111/24"
- "set policy-options condition TEST if-route-exists table inet.0"
description: "condition if-route-exists with host bits set"

- type: commit_check_accepts
node: dut
config_lines:
- "set policy-options condition TEST if-route-exists 192.168.1.0/24 table inet.0"
- "set policy-options condition TEST if-route-exists 192.168.1.0/24"
- "set policy-options condition TEST if-route-exists table inet.0"
description: "condition if-route-exists with valid prefix"

# --- Contexts where Junos ACCEPTS host bits ---
Expand Down
3 changes: 2 additions & 1 deletion snapshots/junos_commit_check/configs/rejects-condition/show_configuration_|_display_set.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
set system host-name rejects-condition
set policy-options condition TEST if-route-exists 192.168.1.111/24 table inet.0
set policy-options condition TEST if-route-exists 192.168.1.111/24
set policy-options condition TEST if-route-exists table inet.0
29 changes: 0 additions & 29 deletions snapshots/junos_commit_check/validation/sickbay.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,32 +26,3 @@ entries:
skip:
skip_type: dont_run
reason: "commit check lab: configs are parse-warning test fixtures, not full devices"
# parse_warnings: Batfish does not yet flag unnormalized prefixes in these contexts
- hostname: rejects-static
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized static route prefixes (batfish/batfish#9928)"
- hostname: rejects-aggregate
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized aggregate route prefixes (batfish/batfish#9928)"
- hostname: rejects-generate
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized generate route prefixes (batfish/batfish#9928)"
- hostname: rejects-ospf-area-range
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized OSPF area-range prefixes (batfish/batfish#9928)"
- hostname: rejects-firewall-address
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized firewall address prefixes (batfish/batfish#9928)"
- hostname: rejects-firewall-next-ip
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized firewall next-ip prefixes (batfish/batfish#9928)"
- hostname: rejects-condition
test_name: test_parse_warnings
skip:
reason: "Batfish does not yet flag unnormalized condition if-route-exists prefixes (batfish/batfish#9928)"
Loading