[codex] Move legacy whole-archive flags to the graveyard#29939
Draft
dzbarsky wants to merge 1 commit into
Draft
Conversation
Member
|
this one is still used in google |
--incompatible_remove_legacy_whole_archive was introduced disabled in February 2019 by e5735fd and enabled by default in September 2019 by 799328f. Since then, --legacy_whole_archive only affected builds that explicitly restored the pre-migration behavior. Return the established values from the private Starlark compatibility accessors and retain deprecated graveyard no-ops so existing command lines remain accepted. Update the linking tests to cover the established behavior. RELNOTES: --legacy_whole_archive and --incompatible_remove_legacy_whole_archive are now deprecated no-ops.
dzbarsky
force-pushed
the
codex/remove-legacy-whole-archive-flags
branch
from
701d78d to
15cdc1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--incompatible_remove_legacy_whole_archivewas introduced disabled in February 2019 by e5735fd27d and enabled by default in September 2019 by 799328f8e0.--legacy_whole_archivewas retained as a rollback control and only affected builds that explicitly restored the pre-migration behavior.This moves both flags out of
CppOptions, returns the established values from the private Starlark compatibility accessors, and retains deprecated graveyard no-ops so existing command lines remain accepted. The linking tests now cover the established behavior without rollback flags.The rules_cc dead-code cleanup is bazelbuild/rules_cc#768.
Validation:
bazel test --jobs=3 --disk_cache=/private/tmp/bazel-pr-disk-cache //src/test/java/com/google/devtools/build/lib/packages/semantics:ConsistencyTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CppLinkActionTest //src/test/java/com/google/devtools/build/lib/rules/cpp:LibraryLinkingTest.