[codex] Remove the legacy whole-archive heuristic#768
Draft
dzbarsky wants to merge 1 commit into
Draft
Conversation
--incompatible_remove_legacy_whole_archive was introduced disabled in Bazel in February 2019 by e5735fd27d and enabled by default in September 2019 by 799328f8e0. The legacy heuristic has therefore been disabled by default since Bazel 1.0. Remove the unreachable compatibility heuristic. Explicit whole_archive requests and alwayslink libraries continue to set is_whole_archive.
Member
|
i was recently talking to @trybka about this and it's definitely still used in google |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--incompatible_remove_legacy_whole_archivewas introduced disabled in Bazel in February 2019 by e5735fd27d and enabled by default in September 2019 by 799328f8e0. The legacy rules_cc heuristic has therefore been disabled by default since Bazel 1.0.This removes
_need_whole_archiveand uses the explicitwhole_archiverequest directly. Explicitwhole_archiverequests andalwayslinklibraries continue to setis_whole_archive.The Bazel option cleanup is bazelbuild/bazel#29939.
Validation:
buildifier -mode=check cc/private/link/finalize_link_action.bzl,bash -n tests/integration/cc_shared_library_tests.sh, andbazel test --jobs=3 --disk_cache=/private/tmp/bazel-pr-disk-cache //tests/cc/common:cc_common_tests //tests/alwayslink_srcs:alwayslink_test. The editedcc_shared_library_teststarget is Linux-only and is intentionally incompatible with the macOS host platform.