Starlarkify dynamic_library_symlink2 and solib_symlink_action#763
Open
dzbarsky wants to merge 1 commit into
Open
Starlarkify dynamic_library_symlink2 and solib_symlink_action#763dzbarsky wants to merge 1 commit into
dzbarsky wants to merge 1 commit into
Conversation
Declare shareable solib artifacts and register symlink actions from Starlark. Preserve explicit solib paths and runtime_solib_dir_base selection, with analysis and action execution coverage for both callers.
dzbarsky
force-pushed
the
codex/starlarkify-solib-symlink-actions
branch
from
9f3b304 to
b15cc48
Compare
dzbarsky
changed the title
Collaborator
|
I have a change in review internally that does these two as well as dynamic_library_soname and dynamic_library_symlink (had to wait for a bazel release for the latter) |
Contributor
Author
|
Feel free to close out whichever ones are moot. Might make sense to land the ones not blocked on bazel release separately though, as a bazel upgrade can force a rules_cc bump but not vice versa. In other words rules_cc should support previous bazel versions gracefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
_cc_internal.dynamic_library_symlink2and_cc_internal.solib_symlink_actionwithcreate_solib_symlink, which declares a shareable artifact and registersactions.symlinkwith the dynamic library as its input.dynamic_library_symlink2retains<solib_directory>/<path>, whilesolib_symlink_actionretains<runtime_solib_dir_base or solib_directory>/<artifact.basename>.The generated paths, shareable artifacts, symlink targets, and metadata propagation are preserved. The Starlark actions use the standard
Symlinkmnemonic instead of the nativeSolibSymlinkmnemonic.