Fix '.format()' issue with 'find' {} placeholder (double braces addition), escaped slash and reordering of arguments#104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sync.py (fetch_symlinks), Python's
.format()interprets {} as a placeholder and tries to replace it with a positional argument at index 0. This causes the command string to be processed incorrectly before reaching bash.The braces are intended for find, where {} instead should be replaced on runtime by the returned path. Suggested solution is to add double braces to find.
The escaping for the -exec action leads to error. By putting \ in bash, the slash is escaped, leading to the semicolon not being escaped. Suggested solution here is updating
\\;to\;Warning appears regarding the order of the arguments. Order should be updated with the logic that -mindepth and -maxdepth should be before ! and before -type.
Final solution:
And: